Aitozi commented on code in PR #4497:
URL: https://github.com/apache/paimon/pull/4497#discussion_r1865220783
##########
paimon-core/src/main/java/org/apache/paimon/manifest/ManifestFile.java:
##########
@@ -197,14 +198,18 @@ public boolean isCacheEnabled() {
}
public ManifestFile create() {
+ return create(null);
+ }
+
+ public ManifestFile create(List<Predicate> filters) {
RowType entryType =
VersionedObjectSerializer.versionType(ManifestEntry.SCHEMA);
return new ManifestFile(
fileIO,
schemaManager,
partitionType,
- new ManifestEntrySerializer(),
+ ManifestEntrySerializer.getInstance(),
entryType,
- fileFormat.createReaderFactory(entryType),
+ fileFormat.createReaderFactory(entryType, filters),
Review Comment:
In the writer node, it could still may need to read more than one bucket
entry from the manifest if the parallelism is lower than the bucket number
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
