Re: [PR] [core] Fix Identifier should parse backquote. [paimon]

[via GitHub]

LinMingQiang commented on PR #5390:
URL: https://github.com/apache/paimon/pull/5390#issuecomment-2785103472

   > > > Thanks for your reply, we may need to consider the following 
scenairos. <img alt="image" width="1195" 
src="https://private-user-images.githubusercontent.com/7313035/430771973-a3fbd5da-ace3-4031-8f5b-1a220d1fc0f6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDM5OTg4NDQsIm5iZiI6MTc0Mzk5ODU0NCwicGF0aCI6Ii83MzEzMDM1LzQzMDc3MTk3My1hM2ZiZDVkYS1hY2UzLTQwMzEtOGY1Yi0xYTIyMGQxZmMwZjYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDQwNyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTA0MDdUMDQwMjI0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NmVlZTZkMjMyY2ZkMDBjZjUwMjBjOWFkOWVhNzY1YTg5MGRmYjFkNzJkNWE5N2M3ZjAyMmFhMjNmNTNiNTAzYiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.8iKINZ0zmHXtvULh4_08WUL7wtOH1Fx3SibrdNf3DlE";>
 <img alt="image" width="766" 
src="https://private-user-images.githubusercontent.com/7313035/430773883-8
 
b72533c-f865-489e-8f70-0ee3984da693.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDM5OTg4NDQsIm5iZiI6MTc0Mzk5ODU0NCwicGF0aCI6Ii83MzEzMDM1LzQzMDc3Mzg4My04YjcyNTMzYy1mODY1LTQ4OWUtOGY3MC0wZWUzOTg0ZGE2OTMucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDQwNyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTA0MDdUMDQwMjI0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9OTA5MWY5MTQ2NjkwZTM2MDUxMjIwMGI0ZmY0N2IzMzMyYjNiOWU1NWIzODg4YTM0MzUwNjJlNzk1NWQxMTQ2NyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.aPe11rh6e9ED98UckClPB_of-nD3xDvewxROy8FAHu4">
   > > 
   > > 
   > > In your example, you create a table called table`#branched. This is no 
problem in Flink-SQL parsing engine, as the backticks are handled correctly. 
But it is not processed in procedure, so the correct table name table`#branched 
cannot be parsed. This is also the purpose of this PR, here we can't just do a 
simple replacement, we need a parser to parse the table name like 
`SparkUtils#catalogAndIdentifier` does .
   > 
   > I believe you also cannot do a simple replacement like currently if you 
want to support any entity (catalog, database or table) with special characters 
in it. For instance if the database name contains a dot:
   > 
   > ```
   > CALL sys.compact(`table` => 
'`my_catalog`.`my_database.containing_dot`.my_table');
   > ```
   
   Sure, @JingsongLi  WDYT. Do we need to implement a parser to parse the table 
name like spark procedure do?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org