LinMingQiang commented on code in PR #5413:
URL: https://github.com/apache/paimon/pull/5413#discussion_r2032400484
##########
paimon-core/src/main/java/org/apache/paimon/utils/FileSystemBranchManager.java:
##########
@@ -137,8 +137,8 @@ private boolean fileExists(Path path) {
}
@Override
- public void fastForward(String branchName) {
- BranchManager.fastForwardValidate(branchName);
+ public void fastForward(String branchName, String currentBranch) {
+ BranchManager.fastForwardValidate(branchName, currentBranch);
checkArgument(branchExists(branchName), "Branch name '%s' doesn't
exist.", branchName);
Review Comment:
Can we add a check in `FastForwardProcedure` before calling
`table.fastForward` ?
Like :
```
FileStoreTable fileStoreTable = (FileStoreTable) table(tableId);
checkArgument(
!branchName.equals(fileStoreTable.snapshotManager().branch()),
"Branch name '%s' do not use in fast-forward.",
branchName);
fileStoreTable.fastForward(branchName);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
