LinMingQiang commented on code in PR #5413:
URL: https://github.com/apache/paimon/pull/5413#discussion_r2032321791
##########
paimon-core/src/main/java/org/apache/paimon/utils/FileSystemBranchManager.java:
##########
@@ -137,8 +137,8 @@ private boolean fileExists(Path path) {
}
@Override
- public void fastForward(String branchName) {
- BranchManager.fastForwardValidate(branchName);
+ public void fastForward(String branchName, String currentBranch) {
+ BranchManager.fastForwardValidate(branchName, currentBranch);
checkArgument(branchExists(branchName), "Branch name '%s' doesn't
exist.", branchName);
Review Comment:
> @LinMingQiang I have debuged and found that `alter table T set
('branch'='test')` cannot change `SnapshotManager#branch()` result, so we
should extract from configOptions like `AbstractFileStoreTable#currentBranch()`.
<img width="1097" alt="image"
src="https://github.com/user-attachments/assets/a9b6d1d3-b4c0-471a-a361-6502fe51a151";
/>
It works in my environment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
