Copilot commented on code in PR #6019:
URL: https://github.com/apache/paimon/pull/6019#discussion_r2275759586
##########
paimon-core/src/main/java/org/apache/paimon/table/source/ReadBuilderImpl.java:
##########
@@ -93,11 +89,12 @@ public ReadBuilder withFilter(Predicate filter) {
@Override
public ReadBuilder withPartitionFilter(Map<String, String> partitionSpec) {
if (partitionSpec != null) {
- this.partitionFilter =
+ PartitionPredicate partitionPredicate =
fromPredicate(
partitionType,
createPartitionPredicate(
partitionSpec, partitionType,
defaultPartitionName));
+ withPartitionFilter(partitionPredicate);
Review Comment:
The method creates a partitionPredicate but doesn't assign it to the
instance field. The call to `withPartitionFilter(partitionPredicate)` should be
`this.partitionFilter = partitionPredicate;` to properly set the field.
##########
paimon-core/src/test/java/org/apache/paimon/table/TableTestBase.java:
##########
@@ -88,7 +88,7 @@ public void after() throws IOException {
// assert all connections are closed
Predicate<Path> pathPredicate = path ->
path.toString().contains(tempPath.toString());
assertThat(TraceableFileIO.openInputStreams(pathPredicate)).isEmpty();
- assertThat(TraceableFileIO.openOutputStreams(pathPredicate)).isEmpty();
+ assertThat(TraceableFileIO.openOutputStreams(pathPredicate).isEmpty());
Review Comment:
The assertion is missing `.isEmpty()` call. The current code calls
`isEmpty()` on the result but doesn't assert it. Should be
`assertThat(TraceableFileIO.openOutputStreams(pathPredicate)).isEmpty();`
```suggestion
assertThat(TraceableFileIO.openOutputStreams(pathPredicate)).isEmpty();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
