Zouxxyy commented on code in PR #6506:
URL: https://github.com/apache/paimon/pull/6506#discussion_r2483182653
##########
paimon-common/src/main/java/org/apache/paimon/predicate/Transform.java:
##########
Review Comment:
I believe we can introduce a `Literal` object in the future, so that our
inputs will only be of either `Literal` or `FieldRef` type now.
##########
paimon-common/src/main/java/org/apache/paimon/predicate/LeafPredicate.java:
##########
@@ -30,76 +30,73 @@
import java.io.IOException;
import java.io.ObjectInputStream;
import java.io.ObjectOutputStream;
+import java.util.Collections;
import java.util.List;
import java.util.Objects;
import java.util.Optional;
import static org.apache.paimon.utils.InternalRowUtils.get;
/** Leaf node of a {@link Predicate} tree. Compares a field in the row with
literals. */
-public class LeafPredicate implements Predicate {
+public class LeafPredicate extends TransformPredicate {
Review Comment:
Since LeafPredicate extends TransformPredicate, and we have
```
T visit(LeafPredicate predicate);
T visit(TransformPredicate predicate);
```
Maybe we can combine them in the future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
