JingsongLi commented on code in PR #6506:
URL: https://github.com/apache/paimon/pull/6506#discussion_r2485910937
##########
paimon-common/src/main/java/org/apache/paimon/predicate/LeafPredicate.java:
##########
@@ -30,76 +30,70 @@
import java.io.IOException;
import java.io.ObjectInputStream;
import java.io.ObjectOutputStream;
+import java.util.Collections;
import java.util.List;
import java.util.Objects;
import java.util.Optional;
import static org.apache.paimon.utils.InternalRowUtils.get;
/** Leaf node of a {@link Predicate} tree. Compares a field in the row with
literals. */
-public class LeafPredicate implements Predicate {
+public class LeafPredicate extends TransformPredicate {
private static final long serialVersionUID = 1L;
Review Comment:
change ser id.
##########
paimon-common/src/main/java/org/apache/paimon/predicate/FieldTransform.java:
##########
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.paimon.predicate;
+
+import org.apache.paimon.data.InternalRow;
+import org.apache.paimon.types.DataType;
+
+import java.util.Collections;
+import java.util.List;
+import java.util.Objects;
+
+import static org.apache.paimon.utils.InternalRowUtils.get;
+
+/** Transform that extracts a field from a row. */
+public class FieldTransform implements Transform {
+
Review Comment:
Add ser id.
##########
paimon-common/src/main/java/org/apache/paimon/predicate/ConcatTransform.java:
##########
@@ -35,4 +35,9 @@ public ConcatTransform(List<Object> inputs) {
public BinaryString transform(List<BinaryString> inputs) {
return BinaryString.concat(inputs);
}
+
+ @Override
+ public Transform withNewInputs(List<Object> inputs) {
Review Comment:
copy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
