leaves12138 commented on code in PR #6752:
URL: https://github.com/apache/paimon/pull/6752#discussion_r2608918301
##########
paimon-common/src/main/java/org/apache/paimon/globalindex/GlobalIndexResult.java:
##########
@@ -55,16 +69,53 @@ static GlobalIndexResult createEmpty() {
/** Returns a new {@link GlobalIndexResult} from supplier. */
static GlobalIndexResult create(Supplier<RoaringNavigableMap64> supplier) {
+ return create(supplier, null);
+ }
+
+ /** Returns a new {@link GlobalIndexResult} from supplier. */
+ static GlobalIndexResult create(
+ Supplier<RoaringNavigableMap64> supplier, @Nullable ScoreFunction
scoreFunction) {
LazyField<RoaringNavigableMap64> lazyField = new LazyField<>(supplier);
- return lazyField::get;
+ return new GlobalIndexResult() {
+ @Override
+ public RoaringNavigableMap64 results() {
+ return lazyField.get();
+ }
+
+ @Nullable
+ @Override
+ public ScoreFunction scoreFunction() {
+ return scoreFunction;
+ }
+ };
}
/** Returns a new {@link GlobalIndexResult} from {@link Range}. */
static GlobalIndexResult fromRange(Range range) {
return create(
() -> {
RoaringNavigableMap64 result64 = new
RoaringNavigableMap64();
- result64.addRange(range);
+ if (range.from == range.to) {
+ result64.add(range.from);
+ } else {
+ result64.addRange(range);
+ }
Review Comment:
Good idea
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
