JingsongLi commented on code in PR #6794:
URL: https://github.com/apache/paimon/pull/6794#discussion_r2608997277
##########
paimon-core/src/main/java/org/apache/paimon/globalindex/GlobalIndexScanBuilderImpl.java:
##########
@@ -19,109 +19,171 @@
package org.apache.paimon.globalindex;
import org.apache.paimon.Snapshot;
-import org.apache.paimon.data.BinaryRow;
+import org.apache.paimon.fs.FileIO;
import org.apache.paimon.index.GlobalIndexMeta;
import org.apache.paimon.index.IndexFileHandler;
+import org.apache.paimon.index.IndexPathFactory;
import org.apache.paimon.manifest.IndexManifestEntry;
-import org.apache.paimon.table.FileStoreTable;
+import org.apache.paimon.options.Options;
+import org.apache.paimon.partition.PartitionPredicate;
+import org.apache.paimon.types.RowType;
import org.apache.paimon.utils.Filter;
+import org.apache.paimon.utils.Pair;
import org.apache.paimon.utils.Range;
import org.apache.paimon.utils.SnapshotManager;
+import java.util.Collection;
import java.util.List;
+import java.util.Map;
import java.util.Objects;
-import java.util.Set;
import java.util.stream.Collectors;
/** Implementation of {@link GlobalIndexScanBuilder}. */
public class GlobalIndexScanBuilderImpl implements GlobalIndexScanBuilder {
- private final FileStoreTable fileStoreTable;
+ private final Options options;
+ private final RowType rowType;
+ private final FileIO fileIO;
+ private final IndexPathFactory indexPathFactory;
private final SnapshotManager snapshotManager;
-
- private Long snapshotId;
- private BinaryRow partition;
- private Long rowRangeStart;
- private Long rowRangeEnd;
-
- public GlobalIndexScanBuilderImpl(FileStoreTable fileStoreTable) {
- this.fileStoreTable = fileStoreTable;
- this.snapshotManager = fileStoreTable.snapshotManager();
+ private final IndexFileHandler indexFileHandler;
+
+ private Snapshot snapshot;
+ private PartitionPredicate partitionPredicate;
+ private Range rowRange;
+
+ public GlobalIndexScanBuilderImpl(
+ Options options,
+ RowType rowType,
+ FileIO fileIO,
+ IndexPathFactory indexPathFactory,
+ SnapshotManager snapshotManager,
+ IndexFileHandler indexFileHandler) {
+ this.options = options;
+ this.rowType = rowType;
+ this.fileIO = fileIO;
+ this.indexPathFactory = indexPathFactory;
+ this.snapshotManager = snapshotManager;
+ this.indexFileHandler = indexFileHandler;
}
@Override
public GlobalIndexScanBuilder withSnapshot(long snapshotId) {
- this.snapshotId = snapshotId;
+ this.snapshot = snapshotManager.snapshot(snapshotId);
+ return this;
+ }
+
+ @Override
+ public GlobalIndexScanBuilder withSnapshot(Snapshot snapshot) {
+ this.snapshot = snapshot;
return this;
}
@Override
- public GlobalIndexScanBuilder withPartition(BinaryRow binaryRow) {
- this.partition = binaryRow;
+ public GlobalIndexScanBuilder withPartitionPredicate(PartitionPredicate
partitionPredicate) {
+ this.partitionPredicate = partitionPredicate;
return this;
}
@Override
public GlobalIndexScanBuilder withRowRange(Range rowRange) {
- this.rowRangeStart = rowRange.from;
- this.rowRangeEnd = rowRange.to;
+ this.rowRange = rowRange;
return this;
}
@Override
public RowRangeGlobalIndexScanner build() {
- Objects.requireNonNull(rowRangeStart, "rowRangeStart must not be
null");
- Objects.requireNonNull(rowRangeEnd, "rowRangeEnd must not be null");
+ Objects.requireNonNull(rowRange, "rowRange must not be null");
List<IndexManifestEntry> entries = scan();
- return new RowRangeGlobalIndexScanner(fileStoreTable, rowRangeStart,
rowRangeEnd, entries);
+ return new RowRangeGlobalIndexScanner(
+ options, rowType, fileIO, indexPathFactory, rowRange, entries);
}
@Override
- public Set<Range> shardList() {
- return scan().stream()
- .map(
- entry -> {
- GlobalIndexMeta globalIndexMeta =
entry.indexFile().globalIndexMeta();
- if (globalIndexMeta == null) {
- return null;
- }
- long start = globalIndexMeta.rowRangeStart();
- long end = globalIndexMeta.rowRangeEnd();
- return new Range(start, end);
- })
- .filter(Objects::nonNull)
- .collect(Collectors.toSet());
+ public List<Range> shardList() {
+ Map<String, List<Range>> indexRanges =
+ scan().stream()
Review Comment:
Use for loop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
