JingsongLi commented on code in PR #6794:
URL: https://github.com/apache/paimon/pull/6794#discussion_r2609006087
##########
paimon-core/src/main/java/org/apache/paimon/operation/RawFileSplitRead.java:
##########
@@ -153,14 +155,32 @@ public SplitRead<InternalRow> withLimit(@Nullable Integer
limit) {
}
@Override
- public SplitRead<InternalRow> withRowRanges(@Nullable List<Range>
rowRanges) {
- this.rowRanges = rowRanges;
- return this;
+ public RecordReader<InternalRow> createReader(Split s) throws IOException {
+ if (s instanceof DataSplit) {
+ return createReader((DataSplit) s, null);
+ } else {
+ return createReader((IndexedSplit) s);
+ }
}
- @Override
- public RecordReader<InternalRow> createReader(Split s) throws IOException {
- DataSplit split = (DataSplit) s;
+ private RecordReader<InternalRow> createReader(IndexedSplit indexedSplit)
throws IOException {
Review Comment:
You can create a dedicated PR to finish this refactor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
