Stefanietry commented on code in PR #6394:
URL: https://github.com/apache/paimon/pull/6394#discussion_r2631183129
##########
paimon-core/src/main/java/org/apache/paimon/io/KeyValueFileReaderFactory.java:
##########
@@ -262,6 +300,16 @@ public KeyValueFileReaderFactory build(
DeletionVector.Factory dvFactory,
boolean projectKeys,
@Nullable List<Predicate> filters) {
+ return build(partition, bucket, dvFactory, projectKeys, filters,
null);
+ }
+
+ public KeyValueFileReaderFactory build(
+ BinaryRow partition,
+ int bucket,
+ DeletionVector.Factory dvFactory,
+ boolean projectKeys,
+ @Nullable List<Predicate> filters,
+ @Nullable DataSplit split) {
Review Comment:
It has been re-implemented based on ChainSplit and ChainRead. Please help
review it again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
