JingsongLi commented on code in PR #6394:
URL: https://github.com/apache/paimon/pull/6394#discussion_r2641784084


##########
paimon-core/src/main/java/org/apache/paimon/catalog/AbstractCatalog.java:
##########
@@ -385,7 +386,10 @@ public void createTable(Identifier identifier, Schema 
schema, boolean ignoreIfEx
         checkNotSystemTable(identifier, "createTable");
         validateCreateTable(schema, false);
         validateCustomTablePath(schema.options());
-
+        SchemaValidation.validateChainTableOptions(

Review Comment:
   Why not in `SchemaValidation.validateTableSchema`?



##########
paimon-spark/paimon-spark-common/src/main/java/org/apache/paimon/spark/SparkGenericCatalog.java:
##########
@@ -211,6 +212,7 @@ public Table createTable(
             return sparkCatalog.createTable(ident, schema, partitions, 
properties);
         } else {
             // delegate to the session catalog
+            SchemaValidation.validateChainTableOptions(properties, null, 
partitions.length != 0);

Review Comment:
   Why not in `SchemaValidation.validateTableSchema`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to