XiaoHongbo-Hope commented on code in PR #6808:
URL: https://github.com/apache/paimon/pull/6808#discussion_r2634211279
##########
paimon-python/pypaimon/catalog/filesystem_catalog.py:
##########
@@ -64,7 +65,7 @@ def create_database(self, name: str, ignore_if_exists: bool,
properties: Optiona
def get_table(self, identifier: Union[str, Identifier]) -> Table:
if not isinstance(identifier, Identifier):
identifier = Identifier.from_string(identifier)
- if CoreOptions.SCAN_FALLBACK_BRANCH in self.catalog_options:
+ if self.catalog_options.contains(CoreOptions.SCAN_FALLBACK_BRANCH):
raise ValueError(f"Unsupported CoreOption
{CoreOptions.SCAN_FALLBACK_BRANCH}")
table_path = self.get_table_path(identifier)
table_schema = self.get_table_schema(identifier)
Review Comment:
check `schema.options.get(CoreOptions.AUTO_CREATE):` in create_table here,
schema.options is dict of str, but CoreOptions.AUTO_CREATE is config option,
add test case to cover it. `schema.options.get(CoreOptions.TYPE)` too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
