XiaoHongbo-Hope commented on code in PR #6808:
URL: https://github.com/apache/paimon/pull/6808#discussion_r2634232836
##########
paimon-python/pypaimon/table/file_store_table.py:
##########
@@ -140,9 +141,9 @@ def create_row_key_extractor(self) -> RowKeyExtractor:
raise ValueError(f"Unsupported bucket mode: {bucket_mode}")
def copy(self, options: dict) -> 'FileStoreTable':
- if CoreOptions.BUCKET in options and options.get(CoreOptions.BUCKET)
!= self.options.get(CoreOptions.BUCKET):
+ if CoreOptions.BUCKET.key() in options and
options.get(CoreOptions.BUCKET.key()) != self.options.bucket():
raise ValueError("Cannot change bucket number")
Review Comment:
options is a dict of str and self.options.bucket() will return int, will
this work well? Can you add a case or assertion to cover here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
