wzhero1 commented on code in PR #6858:
URL: https://github.com/apache/paimon/pull/6858#discussion_r2652133274
##########
paimon-core/src/main/java/org/apache/paimon/table/system/AuditLogTable.java:
##########
@@ -722,19 +699,14 @@ public void setRowKind(RowKind kind) {
@Override
public boolean isNullAt(int pos) {
- if (indexMapping[pos] < 0) {
- // row kind is always not null
- return false;
- }
- return super.isNullAt(pos);
+ return pos == rowkindPos ? false : super.isNullAt(pos);
Review Comment:
For primary-key tables, both `rowKind` and `sequenceNumber` are already
extracted in `KeyValueTableRead`. This logic here is specifically for
append-only tables, where both fields would be null by default. The special
handling for rowKindPos is needed because for `AuditLogTable`, append-only
records should explicitly show rowKind as `INSERT` rather than null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]