wzhero1 commented on code in PR #6858:
URL: https://github.com/apache/paimon/pull/6858#discussion_r2652146335
##########
paimon-core/src/main/java/org/apache/paimon/operation/MergeFileSplitRead.java:
##########
@@ -408,4 +428,68 @@ public UserDefinedSeqComparator createUdsComparator() {
return UserDefinedSeqComparator.create(
readerFactoryBuilder.readValueType(), sequenceFields,
sequenceOrder);
}
+
+ /**
+ * Collects system field extractors for the requested read type.
+ *
+ * @param readType the requested read type (may contain system fields)
+ * @return list of extractors for system fields present in readType
+ */
+ private List<KeyValueSystemFieldsRecordReader.SystemFieldExtractor>
+ collectSystemFieldExtractors(RowType readType) {
+ if (readType == null) {
Review Comment:
Agreed it's unlikely to be `null` in practice, but this check is intentional
for method self-containment. It ensures the method handles all input states
gracefully without relying on caller guarantees - a minor redundancy for
defensive completeness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
