lxy-9602 commented on code in PR #6994:
URL: https://github.com/apache/paimon/pull/6994#discussion_r2681207830
##########
paimon-common/src/main/java/org/apache/paimon/globalindex/GlobalIndexIOMeta.java:
##########
@@ -27,11 +29,18 @@ public class GlobalIndexIOMeta {
private final String fileName;
private final long fileSize;
private final byte[] metadata;
+ @Nullable private final String externalPath;
Review Comment:
The `GlobalIndexIOMeta` is intended to be a meta interface for plugin
authors. However, including an external path in it might be confusing for
users, as it adds complexity and is not intuitive in this context.
Would it make more sense to store only the file_path in `GlobalIndexIOMeta`,
while leaving the external path to be handled internally by the Paimon
framework? This way, the external path could be extracted and managed within
the `IndexFileMeta`, simplifying the API for plugin authors and ensuring a
clearer separation of concerns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
