lxy-9602 commented on code in PR #6994:
URL: https://github.com/apache/paimon/pull/6994#discussion_r2681220382
##########
paimon-core/src/main/java/org/apache/paimon/utils/FileStorePathFactory.java:
##########
@@ -130,6 +135,10 @@ public Path indexPath() {
return new Path(root, INDEX_PATH);
}
+ public Path globalIndexRootDir() {
+ return globalIndexExternalRootDir != null ? globalIndexExternalRootDir
: indexPath();
+ }
Review Comment:
If `globalIndexExternalRootDir` is not null, the index path be
`external_index_path/index/` or `external_index_path/`? The first one maybe
better? Not sure whether retaining the `index/` is necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]