wzhero1 commented on code in PR #6933:
URL: https://github.com/apache/paimon/pull/6933#discussion_r2711044776
##########
paimon-core/src/main/java/org/apache/paimon/table/source/ValueContentRowDataRecordIterator.java:
##########
@@ -19,16 +19,32 @@
package org.apache.paimon.table.source;
import org.apache.paimon.KeyValue;
+import org.apache.paimon.data.GenericRow;
import org.apache.paimon.data.InternalRow;
+import org.apache.paimon.data.JoinedRow;
import org.apache.paimon.reader.RecordReader;
import java.io.IOException;
+import java.util.HashMap;
+import java.util.Map;
/** A {@link RecordReader.RecordIterator} mapping a {@link KeyValue} to its
value. */
public class ValueContentRowDataRecordIterator extends
ResetRowKindRecordIterator {
+ public static final String KEY_VALUE_SEQUENCE_NUMBER_ENABLED =
+ "key-value.sequence_number.enabled";
+ private final boolean keyValueSequenceNumberEnabled;
+
public
ValueContentRowDataRecordIterator(RecordReader.RecordIterator<KeyValue>
kvIterator) {
+ this(kvIterator, new HashMap<>(1));
+ }
+
+ public ValueContentRowDataRecordIterator(
+ RecordReader.RecordIterator<KeyValue> kvIterator, Map<String,
String> schemaOptions) {
Review Comment:
I'd prefer to avoid being too tightly coupled to `sequenceNumberEnabled`
here. Passing the entire `schemaOption` map provides better flexibility for
future extensions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
