JingsongLi commented on code in PR #7211:
URL: https://github.com/apache/paimon/pull/7211#discussion_r2795939088
##########
paimon-python/pypaimon/read/split_read.py:
##########
@@ -467,7 +473,21 @@ def create_reader(self) -> RecordReader:
lambda files=need_merge_files:
self._create_union_reader(files)
)
- return ConcatBatchReader(suppliers)
+ merge_reader = ConcatBatchReader(suppliers)
+ if self.predicate is not None:
+ # Only apply filter when all predicate columns are in read_type
(e.g. projected schema).
Review Comment:
What we are returning here is complete row, right? So this check should be
applicable to all table modes? That shouldn't be added here, it should be
verified in ReadBuilder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
