XiaoHongbo-Hope commented on code in PR #7211:
URL: https://github.com/apache/paimon/pull/7211#discussion_r2805022029
##########
paimon-python/pypaimon/read/scanner/file_scanner.py:
##########
@@ -434,7 +434,7 @@ def _filter_manifest_entry(self, entry: ManifestEntry) ->
bool:
else:
if not self.predicate:
return True
- if self.predicate_for_stats is None:
+ if self.predicate_for_stats is None or self.data_evolution:
Review Comment:
> Create a separate `if`. And we should add comments to this if, explain why
there is no filtering done here.
Updated.
##########
paimon-python/pypaimon/read/split_read.py:
##########
@@ -449,6 +451,10 @@ def __init__(
actual_split = split.data_split()
super().__init__(table, predicate, read_type, actual_split,
row_tracking_enabled)
+ def _push_down_predicate(self) -> Optional[Predicate]:
+ # Do not push predicate to file readers;
Review Comment:
> Detailed comments, why not push predicate.
Added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
