JingsongLi commented on PR #7258: URL: https://github.com/apache/paimon/pull/7258#issuecomment-3887693492
Hi @tonymtu @XiaoHongbo-Hope , maybe > > > Thanks! Can we use a small case to reproduce the issue, and add it in CI to avoid such issues in future? > > > > > > Maybe it is hard to cover the issue with a reliable test. When running the full test suite, `import` in earlier tests can silently mask the issue. > > A static analysis check (e.g. mypy) can be a proper way to catch this. However, introducing mypy into CI is a broader change that can surface many existing type issues across the codebase? > > Got your point. Can we use a subprocess to test the issue, or we just introduce `mypy` into CI ? We should try our best to catch these issues in CI rather than on the user side. Can you provide us some suggestion on it? @JingsongLi I don't have any good suggestions. I'm not very familiar with Python engineering testing. Perhaps it's a problem with our CI testing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
