tonymtu commented on PR #7258: URL: https://github.com/apache/paimon/pull/7258#issuecomment-3888725632
Hi @JingsongLi @XiaoHongbo-Hope . I'd prefer to split this into two separate efforts: - This PR: fix the immediate bug (explicit import pyarrow.xxx). - A follow-up effort: enable mypy checking in CI to prevent this class of issues. I noticed there's already a [mypy] section in dev/cfg.ini but it's not wired into lint-python.sh, presumably because enabling it across the full codebase would surface too many existing issues at once. > Suggestions on enabling [mypy] by Claude Opus: > flake8 (our current linter) cannot catch this — it's a style checker, not a type checker. Only mypy can detect unresolved submodule attribute access. A practical approach for the follow-up would be running mypy only on files changed in each PR (git diff --name-only), so we can incrementally enforce type checking without a massive one-time fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
