XiaoHongbo-Hope commented on code in PR #207:
URL: https://github.com/apache/paimon-rust/pull/207#discussion_r3039896536
##########
crates/paimon/src/table/table_scan.rs:
##########
@@ -667,14 +694,17 @@ impl<'a> TableScan<'a> {
if let Some(files) = data_deletion_files {
builder = builder.with_data_deletion_files(files);
}
+ if let Some(row_ranges) = split_row_ranges {
+ builder = builder.with_row_ranges(row_ranges);
+ }
splits.push(builder.build()?);
}
}
// Apply limit pushdown only when there are no data predicates.
// With data predicates, merged_row_count() reflects pre-filter row
counts,
// so stopping early could return fewer rows than the limit after
filtering.
- let splits = if self.data_predicates.is_empty() {
+ let splits = if self.data_predicates.is_empty() &&
self.row_ranges.is_none() {
Review Comment:
> nit: may also update comment to reflect newly row_ranges
Added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
