XiaoHongbo-Hope commented on code in PR #207:
URL: https://github.com/apache/paimon-rust/pull/207#discussion_r3039959646
##########
crates/paimon/src/arrow/reader.rs:
##########
@@ -1355,6 +1474,112 @@ fn exact_parquet_value<'a, T>(
}
}
+/// Expand row_ranges into a flat sequence of selected row IDs for a file.
+fn expand_selected_row_ids(first_row_id: i64, row_count: i64, row_ranges:
&[RowRange]) -> Vec<i64> {
+ let file_end = first_row_id + row_count - 1;
Review Comment:
> what if row_count is 0, is expected file_end will be less than
first_row_id?
Added an early return.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
