JunRuiLee commented on PR #7832:
URL: https://github.com/apache/paimon/pull/7832#issuecomment-4475271564
Thanks @leaves12138 for the careful review.
I fixed the first two correctness issues:
1. PartialUpdateMergeFunction and AggregateMergeFunction now preserve the
winning input record’s snapshotId when returning a newly built KeyValue, so
compaction no longer stamps UNKNOWN_SNAPSHOT_ID into
_SEQUENCE_NUMBER.
2. KeyValueBuffer now preserves snapshotId when snapshot ordering is
enabled, so lookup compaction buffer spill does not lose it during binary
serialization/deserialization.
I also added regression coverage for merge-function snapshotId
preservation, partial-update compaction, aggregate compaction, and lookup
buffer spill.
For the ALTER TABLE concern: this option is annotated as immutable, so
enabling it via ALTER on a table with existing snapshots is rejected;
empty-table ALTER remains allowed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
