JunRuiLee commented on code in PR #7832:
URL: https://github.com/apache/paimon/pull/7832#discussion_r3257007200
##########
paimon-core/src/main/java/org/apache/paimon/mergetree/compact/LookupMergeTreeCompactRewriter.java:
##########
@@ -217,7 +221,8 @@ public MergeFunctionWrapper<ChangelogResult> create(
valueEqualiser,
lookupStrategy,
deletionVectorsMaintainer,
- userDefinedSeqComparator);
+ userDefinedSeqComparator,
+ snapshotSequenceOrdering);
Review Comment:
fixed
##########
paimon-api/src/main/java/org/apache/paimon/CoreOptions.java:
##########
@@ -965,6 +965,20 @@ public InlineElement getDescription() {
.defaultValue(SortOrder.ASCENDING)
.withDescription("Specify the order of sequence.field.");
+ @Immutable
+ public static final ConfigOption<Boolean> SEQUENCE_SNAPSHOT_ORDERING =
+ key("sequence.snapshot-ordering")
+ .booleanType()
+ .defaultValue(false)
+ .withDescription(
+ "When enabled, merge uses the commit snapshot id
as the primary "
Review Comment:
this option is annotated as immutable, so enabling it via ALTER on a table
with existing snapshots is rejected; empty-table ALTER remains allowed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
