leaves12138 commented on PR #1: URL: https://github.com/apache/paimon-cpp/pull/1#issuecomment-4514579784
Thanks for preparing the initial project tooling and contribution docs. I do not think this should merge yet; I found a few migration blockers that will confuse contributors and make the repository metadata inaccurate: 1. `CONTRIBUTING.md` and `docs/code-style.md` ask contributors to install and run `pre-commit`, and list hooks such as `clang-format`, `cpplint`, `cmake-format`, and `codespell`, but this PR does not add `.pre-commit-config.yaml`. As-is, `pre-commit install` / `pre-commit run --all-files` will fail in a fresh checkout. Please either migrate the pre-commit config in this PR or remove/defer those instructions until the config lands. 2. `README.md` / `CONTRIBUTING.md` document Dev Container templates under `.devcontainer/`, and `.gitignore` explicitly keeps `.devcontainer/*.template`, but the PR does not add `.devcontainer/Dockerfile.template` or `.devcontainer/devcontainer.json.template`. Please include the templates or remove the Dev Container section for now. 3. `LICENSE` and `NOTICE` list bundled third-party code under `third_party/` and `src/paimon/...`, but those files are not present in the Apache repository in this PR. For ASF source-release metadata, `LICENSE` / `NOTICE` should describe what is actually bundled in the source tree. Please add these notices together with the code import, or trim them until the corresponding code is present. Minor: `README.md` line 31 has trailing whitespace. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
