leaves12138 commented on PR #1: URL: https://github.com/apache/paimon-cpp/pull/1#issuecomment-4514820522
Thanks for the update. The previous blockers I mentioned look addressed: the pre-commit config and Dev Container templates are now present, and `LICENSE` / `NOTICE` no longer list code that is not in the current source tree. One remaining issue before merge: `.pre-commit-config.yaml` enables `end-of-file-fixer`, but the current diff still shows `\ No newline at end of file` for `LICENSE`, `NOTICE`, and `README.md`. This means `pre-commit run --all-files` would fail or modify these files. Please add a final newline to those files. Minor / non-blocking: the README build section still mentions `git lfs pull` and CMake build commands, while this PR does not yet include `.gitattributes` / LFS-tracked files or `CMakeLists.txt`. If the source/build files will be migrated in a follow-up PR, it may be clearer to mark the build instructions as pending during migration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
