HansiChan commented on PR #7727: URL: https://github.com/apache/paimon/pull/7727#issuecomment-4526030386
Thanks for the detailed review. I pushed a follow-up commit to address the actionable items: - Closed both `table_read` and `table_write` in `_rewrite`. - Changed `list_snapshots()` to reuse `get_snapshots_batch()` instead of loading snapshots sequentially. - Split JSON serialization into a top-level `__serialize()` helper so `__to_dict()` keeps a dictionary-only contract. - Updated `cmd_table_snapshot` to reuse `_load_file_store_table()`. - Added a short comment in `_rewrite` to clarify that maintenance reads from the original table and writes to the target table. - Added TODOs for returning the committed snapshot ID directly from the commit path to avoid the latest-snapshot race. - Added error-path tests for compacting an empty table, `bucket_num=0`, and deletion-vector table rejection. I also verified that `list_snapshots()` is only defined once in the current branch. Validated with: `PYTHONPATH=. python -m pytest pypaimon/tests/table/maintenance_test.py` `PYTHONPATH=. python -m pytest pypaimon/tests/cli_table_test.py -k snapshot` `python -m flake8 --config=dev/cfg.ini pypaimon/common/json_util.py pypaimon/snapshot/snapshot_manager.py pypaimon/table/maintenance.py pypaimon/cli/cli_table.py pypaimon/tests/table/maintenance_test.py` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
