leaves12138 commented on code in PR #7972:
URL: https://github.com/apache/paimon/pull/7972#discussion_r3302753397
##########
paimon-core/src/main/java/org/apache/paimon/operation/commit/ConflictDetection.java:
##########
@@ -131,6 +132,14 @@ public boolean hasRowIdCheckFromSnapshot() {
return rowIdCheckFromSnapshot != null;
}
+ public void setRowIdReassignCheckFromSnapshot(@Nullable Long
rowIdReassignCheckFromSnapshot) {
Review Comment:
Thanks for the suggestion. I think these two snapshot markers should stay
separate because they guard different invariants. `rowIdCheckFromSnapshot` is
used by row-id range / column-level conflict checks, while this one is driven
by `commit.row-id-reassign.last-safe-snapshot` and scans later OVERWRITE
snapshots for row-id reassign or overlapped partition overwrite conflicts
during index build/compact commits. Reusing the existing field would couple two
independent checks and make the COMPACT/index path harder to reason about.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
