leaves12138 commented on code in PR #7972:
URL: https://github.com/apache/paimon/pull/7972#discussion_r3377775235
##########
paimon-core/src/main/java/org/apache/paimon/globalindex/btree/BTreeGlobalIndexBuilder.java:
##########
@@ -133,6 +134,10 @@ public BTreeGlobalIndexBuilder withSnapshot(Snapshot
snapshot) {
return this;
}
+ public Optional<Long> scanSnapshotId() {
Review Comment:
Good catch. This method was a leftover from an earlier approach where the
BTree index builder exposed its scan snapshot to the commit conflict checker.
The current implementation no longer consumes this stateful getter; index
commits are validated by checking added global-index row ranges against current
data-file row ranges during commit. I removed the unused field/getter and the
related assignments in 9c2752005.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
