CrownChu commented on code in PR #7933:
URL: https://github.com/apache/paimon/pull/7933#discussion_r3308132371
##########
paimon-spark/paimon-spark-common/src/main/java/org/apache/paimon/spark/globalindex/DefaultGlobalIndexBuilder.java:
##########
@@ -99,27 +120,38 @@ public CommitMessage build(CloseableIterator<InternalRow>
data) throws IOExcepti
private List<ResultEntry> writePaimonRows(
CloseableIterator<InternalRow> rows, LongCounter rowCounter)
throws IOException {
- GlobalIndexSingletonWriter indexWriter =
- (GlobalIndexSingletonWriter)
- createIndexWriter(table, indexType, indexField,
options);
+ GlobalIndexWriter indexWriter = createIndexWriter(table, indexType,
indexFields, options);
+ boolean multiColumn = indexFields.size() > 1;
try {
- InternalRow.FieldGetter getter =
- InternalRow.createFieldGetter(
- indexField.type(),
readType.getFieldIndex(indexField.name()));
- rows.forEachRemaining(
- row -> {
- Object indexO = getter.getFieldOrNull(row);
- indexWriter.write(indexO);
- rowCounter.add(1);
- });
+ if (multiColumn) {
+ GlobalIndexMultiColumnWriter multiWriter =
+ (GlobalIndexMultiColumnWriter) indexWriter;
+ rows.forEachRemaining(
+ row -> {
Review Comment:
fixed
##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/procedure/CreateGlobalIndexProcedure.java:
##########
@@ -97,7 +106,7 @@ public String[] call(
BTreeIndexTopoBuilder.buildIndexAndExecute(
procedureContext.getExecutionEnvironment(),
table,
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
