CrownChu commented on code in PR #7933:
URL: https://github.com/apache/paimon/pull/7933#discussion_r3308226827
##########
paimon-core/src/main/java/org/apache/paimon/globalindex/GlobalIndexBuilderUtils.java:
##########
@@ -24,18 +24,26 @@
import org.apache.paimon.index.GlobalIndexMeta;
import org.apache.paimon.index.IndexFileMeta;
import org.apache.paimon.index.IndexPathFactory;
+import org.apache.paimon.manifest.ManifestEntry;
import org.apache.paimon.options.Options;
+import org.apache.paimon.schema.SchemaManager;
import org.apache.paimon.table.FileStoreTable;
import org.apache.paimon.types.DataField;
import org.apache.paimon.utils.Range;
+import javax.annotation.Nullable;
+
import java.io.IOException;
import java.util.ArrayList;
+import java.util.HashMap;
import java.util.List;
+import java.util.Map;
Review Comment:
Fix:
Added getIndexedFieldNames helper in both Flink and Spark paths:
- When indexFieldId == MULTI_COLUMN_INDEX_FIELD_ID (-1): resolve column
names from extraFieldIds()
- Otherwise: use the original single-column logic
(rowType.getField(indexFieldId) + optional extraFieldIds)
Both the index filter (which entries are affected) and the error reporting
(conflicted column names) now correctly handle multi-column indexes.
Affected files:
- paimon-flink/.../dataevolution/MergeIntoUpdateChecker.java
-
paimon-spark/paimon-spark-common/.../MergeIntoPaimonDataEvolutionTable.scala
- paimon-spark/paimon-spark-4.0/.../MergeIntoPaimonDataEvolutionTable.scala
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
