JingsongLi commented on PR #8065: URL: https://github.com/apache/paimon/pull/8065#issuecomment-4598261493
LGTM, I didn't find any blocking correctness issues. I checked the skip-file-pruning path and the partition-filter pushdown logic. The change skips the touched-file join when the option is enabled while still preserving safe target partition pruning from the MERGE ON condition. The new tests cover both switch behavior and partition pushdown. Verification: ```bash mvn -Pspark3 -pl paimon-spark/paimon-spark-3.5 -am -Pfast-build -DfailIfNoTests=false -DwildcardSuites=org.apache.paimon.spark.sql.RowTrackingTest -Dtest=none test ``` Result: passed, 33/33 RowTrackingTest cases. I also tried a Spark 4.0 compile, but this local environment is using JDK 8 and the spark4 profile hit ANTLR 4.13.1's Java 11 class version requirement before reaching the changed Spark code, so that failure is environmental rather than PR-specific. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
