JingsongLi commented on code in PR #8065:
URL: https://github.com/apache/paimon/pull/8065#discussion_r3338371968
##########
paimon-spark/paimon-spark-common/src/main/scala/org/apache/paimon/spark/commands/MergeIntoPaimonDataEvolutionTable.scala:
##########
@@ -136,14 +140,16 @@ case class MergeIntoPaimonDataEvolutionTable(
lazy val tableSchema: StructType = v2Table.schema
override def run(sparkSession: SparkSession): Seq[Row] = {
- // Persist the schema that the analyzer evolved in memory (commit deferred
to execution).
- SchemaEvolutionHelper.commitEvolvedSchemaAtExecution(table,
targetRelation, sparkSession)
invokeMergeInto(sparkSession)
Seq.empty[Row]
}
private def invokeMergeInto(sparkSession: SparkSession): Unit = {
- val plan = table.newSnapshotReader().read()
+ val snapshotReader = table.newSnapshotReader()
+ if (table.coreOptions().dataEvolutionMergeIntoSkipFilePruning()) {
Review Comment:
Why not just always push down partition predicates?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
