QuakeWang commented on code in PR #8071:
URL: https://github.com/apache/paimon/pull/8071#discussion_r3339108034
##########
paimon-python/pypaimon/ray/shuffle.py:
##########
@@ -87,14 +87,25 @@ def maybe_apply_repartition(
)
)
- if table.bucket_mode() != BucketMode.HASH_FIXED:
+ bucket_mode = table.bucket_mode()
+ is_primary_key_table = getattr(table, "is_primary_key_table", False)
+
+ if bucket_mode != BucketMode.HASH_FIXED:
Review Comment:
@JingsongLi Good catch. Postpone bucket is different from
dynamic/cross-partition buckets: rows are appended to `bucket-postpone`, are
not visible before compaction, and do not rely on per-writer dynamic bucket
assignment.
I narrowed the guard to reject only HASH_DYNAMIC and CROSS_PARTITION
primary-key Ray writes, and kept POSTPONE_MODE pass-through. Added tests and
updated the docs accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
