JingsongLi commented on code in PR #6575:
URL: https://github.com/apache/paimon/pull/6575#discussion_r3354791628
##########
paimon-common/src/main/java/org/apache/paimon/fs/hadoop/HadoopFileIO.java:
##########
@@ -59,6 +60,8 @@ public class HadoopFileIO implements FileIO,
HadoopOptionsProvider {
private org.apache.paimon.options.Options options;
+ private boolean atomicRenameEnabled = true;
Review Comment:
Could we avoid adding this as a primitive boolean with only the field
initializer? `HadoopFileIO` is `Serializable` (and has a serialization test),
and with the unchanged `serialVersionUID`, instances serialized by an older
Paimon version will deserialize this newly added field as Java default `false`,
not the option default `true`. After a rolling upgrade or restoring from an old
checkpoint/savepoint, `overwriteFileUtf8` would silently skip the atomic rename
path even though `file-io.atomic-rename.enabled` defaults to true. A nullable
`Boolean` treated as true when null, or a custom `readObject` that initializes
the field to true, would preserve the previous behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
