TheR1sing3un commented on PR #7873: URL: https://github.com/apache/paimon/pull/7873#issuecomment-4638041005
> I think the new `CommitMessageSerializer` drops one existing part of `CommitMessage`. > > `CommitMessage` has `index_deletes`, and `is_empty()` treats it as meaningful content. The global-index update path can build messages that only contain `index_deletes` (`build_index_delete_msgs(...)`). But `CommitMessageSerializer.to_dict/from_dict` only round-trips partition, bucket, total_buckets, data/compact increments, and `check_from_snapshot`; it does not serialize `index_deletes`. > > If such a message is shipped through this serializer, the deserialized message will lose the index manifest deletions and the commit can leave stale global-index entries behind. Could we include `index_deletes` in the wire format and add a round-trip test for a message whose only content is `index_deletes`? Nice catch, fixed~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
