JingsongLi commented on code in PR #7873:
URL: https://github.com/apache/paimon/pull/7873#discussion_r3464931944
##########
paimon-python/pypaimon/write/table_update_by_row_id.py:
##########
@@ -382,7 +383,7 @@ def _write_group(self, partition: GenericRow, first_row_id:
int,
CommitMessage(
partition=partition_tuple,
bucket=0,
- new_files=new_files,
+ data_increment=DataIncrement(new_files=new_files),
Review Comment:
This constructor is the one write-side path that still does not carry the
planned bucket count into the new protocol. `FileStoreWrite.prepare_commit()`
and `ShardTableUpdator.prepare_commit()` both set
`total_buckets=self.table.total_buckets`, and `_build_commit_entries()` now
relies on `msg.total_buckets` to avoid rewriting a stale plan with the table
value observed at commit time. Row-id updates created here will fall back to
the current table total, so the new protection is not applied to this path.
Please set `total_buckets` here as well (and ideally add a small regression
alongside the existing total_buckets test).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
