wwj6591812 commented on code in PR #8116:
URL: https://github.com/apache/paimon/pull/8116#discussion_r3385412837
##########
paimon-core/src/main/java/org/apache/paimon/operation/MergeFileSplitRead.java:
##########
@@ -177,6 +189,12 @@ public MergeFileSplitRead forceKeepDelete() {
return this;
}
+ @Override
+ public MergeFileSplitRead withLimit(@Nullable Integer limit) {
Review Comment:
Thanks for the review, @JingsongLi . You are absolutely right — the
withLimit override in MergeFileSplitRead was not reachable through the normal
KeyValueTableRead path because MergeFileSplitReadProvider wraps the reader via
SplitRead.convert(...), and the adapter did not forward withLimit (and
withTopN) to the underlying reader.
I have fixed this by adding withTopN and withLimit forwarding in
SplitRead.convert(...). I also added a new test
testReadWithLimitThroughTableReadPath in PrimaryKeySimpleTableTest to verify
that the limit is actually applied through the full table read path
(KeyValueTableRead -> MergeFileSplitReadProvider -> SplitRead.convert). Please
take another look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
