JingsongLi commented on code in PR #8116:
URL: https://github.com/apache/paimon/pull/8116#discussion_r3384831870
##########
paimon-core/src/main/java/org/apache/paimon/operation/MergeFileSplitRead.java:
##########
@@ -177,6 +189,12 @@ public MergeFileSplitRead forceKeepDelete() {
return this;
}
+ @Override
+ public MergeFileSplitRead withLimit(@Nullable Integer limit) {
Review Comment:
This override is not reached by the normal `KeyValueTableRead` path.
`MergeFileSplitReadProvider` wraps this reader with `SplitRead.convert(...)`,
and that adapter does not override/forward `withLimit`, so
`KeyValueTableRead.config()` ends up calling the default no-op method on the
wrapper. As a result, SQL/table reads still do not apply the new merge-read
limit optimization even though the lower-level `store.newRead().withLimit(...)`
test passes. Please forward `withLimit` in `SplitRead.convert` (and add a
table-read-path test) so this actually takes effect for production reads.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
