QuakeWang opened a new pull request, #404:
URL: https://github.com/apache/paimon-rust/pull/404
<!--
Thank you very much for contributing to Paimon Rust - we are happy that you
want to help us improve it. To help the community review your contribution in
the best possible way, please go through the checklist below, which will get
the contribution into a shape in which it can be best reviewed.
## Contribution Checklist
- Make sure that the pull request corresponds to a [GitHub
issue](https://github.com/apache/paimon-rust/issues). Exceptions are made for
typos in documentation or comments, which need no issue.
- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `cargo test`
passes.
- Each pull request should address only one issue, not mix up code from
multiple issues.
**(The sections below can be removed for hotfixes or typos)**
-->
### Purpose
<!-- Linking this pull request to the issue -->
Linked issue: #257
Aggregation merge engine support existed for fixed and ordinary dynamic
bucket PK tables, but the tests did not explicitly cover dynamic bucket index
restore after table reload, and the docs did not describe Rust's current
basic-mode support boundary. This left regressions around bucket=-1 routing and
Java feature-parity assumptions easy to miss.
<!-- What is the purpose of the change -->
### Brief change log
<!-- Please describe the changes made in this pull request and explain how
they address the issue -->
- Add a DataFusion e2e test for `merge-engine=aggregation` with
`bucket=-1`, small `dynamic-bucket.target-row-num`, duplicate PK writes,
multiple reloads, and final read validation.
- Extend the fixed-bucket aggregation e2e to use multiple buckets.
- Add a core writer test proving `TableWrite::new` accepts `bucket=-1 +
merge-engine=aggregation`.
- Document Rust aggregation basic mode and unsupported **options.**
### Tests
<!-- List unit tests or integration cases to verify this change -->
- `cargo fmt --all -- --check`
- `git diff --check`
- `cargo test -p paimon-datafusion --test pk_tables test_pk_aggregation`
- `cargo test -p paimon-datafusion --test dynamic_bucket_tables
aggregation`
- `cargo test -p paimon --lib aggregation`
- `cargo test -p paimon --lib table_write`
### API and Format
<!-- Does this change affect API or storage format -->
### Documentation
<!-- Does this change introduce a new feature or require documentation
updates -->
Updated SQL docs to clarify aggregation basic-mode support and unsupported
features.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
