JingsongLi commented on code in PR #8219:
URL: https://github.com/apache/paimon/pull/8219#discussion_r3460468185
##########
paimon-flink/paimon-flink-common/src/test/java/org/apache/paimon/flink/FlinkRowWrapperTest.java:
##########
@@ -59,6 +83,36 @@ public void
testExistingBlobDescriptorIsReadableWhenCheckingEnabled() throws Exc
assertThat(wrapper.getBlob(0).toData()).isEqualTo(bytes);
}
+ @Test
+ public void testMissingHttpBlobDescriptorIsNullWhenCheckingEnabled()
throws Exception {
Review Comment:
These new tests still only exercise a single-column descriptor row, but the
enabled path is used on full Flink input rows. With
`blob-write-null-on-missing-file=true`, `FlinkRowWrapper.isNullAt` calls
`row.getBinary(pos)` for every non-null field; a table like `(id INT, b BLOB)`
will therefore probe `id` with `getBinary(0)` and can fail before the blob
field is written. Please add a regression test with at least one non-BLOB
column before the descriptor column and fix the wrapper to check only known
descriptor/BLOB field indexes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
