JingsongLi commented on code in PR #8219:
URL: https://github.com/apache/paimon/pull/8219#discussion_r3465146721
##########
paimon-format/src/main/java/org/apache/paimon/format/blob/BlobFormatWriter.java:
##########
@@ -127,6 +157,33 @@ public void addElement(InternalRow element) throws
IOException {
}
}
+ private void writeNullElement() throws IOException {
+ lengths.add(NULL_LENGTH);
+ if (writeConsumer != null) {
+ writeConsumer.accept(blobFieldName, null);
+ }
+ }
+
+ private static String blobUri(Blob blob) {
+ if (blob instanceof BlobRef) {
+ return ((BlobRef) blob).toDescriptor().uri();
+ }
+ return "unknown";
+ }
+
+ private static boolean isNotFoundError(Throwable throwable) {
+ Throwable current = throwable;
+ while (current != null) {
+ if (current instanceof RuntimeException
+ && current.getMessage() != null
+ && current.getMessage().startsWith("HTTP error code:
404")) {
Review Comment:
This looks quite hacky here. Is it possible not to modify it, or is it
possible to throw a specific exception in HttpUriReader?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
