steFaiz commented on code in PR #8334:
URL: https://github.com/apache/paimon/pull/8334#discussion_r3468156799


##########
paimon-core/src/main/java/org/apache/paimon/operation/DataEvolutionSplitRead.java:
##########


Review Comment:
   Thanks for your contribution!
   
   This class has already been marked as 
   ```java
   TODO: Optimize implementation of this class.
   ```
   
   I think current `createUnionReader` is already hard to comprehend, the 
modified single method have 300 rows and many complicated logic. Is there any 
way to extract a dedicated class for this nested-data-evolution scenario? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to