kerwin-zk commented on PR #8382: URL: https://github.com/apache/paimon/pull/8382#issuecomment-4842686313
Updated the PR with the review follow-ups: - changed the NDV blob type to Paimon-specific `paimon-ndv-theta-sketch-v1`, because this PR uses Paimon's own sidecar container rather than an Iceberg Puffin file; - added a separate `stat-sidecar-` prefix via `statsSidecarFileFactory()` so binary sidecars do not share the JSON statistics file prefix; - reject empty sidecar writes; - validate blob `offset + length` against the actual sidecar file length before reading; - documented the `ndv` metadata property as a cached estimate; - clarified in the PR body that Spark `ANALYZE` / CBO producer wiring is intentionally left for a follow-up PR. Local verification: `mvn -pl paimon-core -am clean test -DskipITs -DfailIfNoTests=false -Dtest=StatisticsBlobMetadataTest,StatisticsTest,StatisticsSidecarFileTest,StatisticsNdvSketchTest,FileStorePathFactoryTest` Result: 15 tests passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
