kerwin-zk commented on PR #8382: URL: https://github.com/apache/paimon/pull/8382#issuecomment-4851642406
Updated the PR with a small follow-up pass based on review feedback: - Added a code comment on the optional Spark NDV sketch path to make the extra scan explicit. - Extracted `blobMetadata` before creating `Statistics` so the sidecar write order is explicit. - Deduplicated repeated statistics JSON reads in local orphan clean while still marking every referenced stats file as used. - Removed the unused public `ThetaSketch.sketchOf(Object...)` helper. - Added missing `@Nullable` annotations to the `Statistics` convenience constructors. I left the per-blob `getFileStatus` optimization for a future batch-read API because the current read path is single-blob oriented. Validated with: - `mvn -Pspark3 -pl paimon-common,paimon-core,paimon-spark/paimon-spark-common spotless:apply` - `mvn -pl paimon-core -DskipITs -DfailIfNoTests=false -Dtest=StatisticsBlobMetadataTest,StatisticsTest,StatisticsSidecarFileTest,StatisticsNdvSketchTest,FileStorePathFactoryTest test` - `mvn -Pspark3 -pl paimon-spark/paimon-spark-3.5 -DskipITs -DwildcardSuites=org.apache.paimon.spark.sql.AnalyzeTableTest test` - `git diff --check` - `mvn -Pspark3 -pl paimon-spark/paimon-spark-3.5 -am -DskipTests -DskipITs install` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
