JingsongLi commented on code in PR #8420: URL: https://github.com/apache/paimon/pull/8420#discussion_r3519257201
########## paimon-python/dev/requirements.txt: ########## @@ -30,9 +30,7 @@ polars>=1,<2; python_version=="3.8" polars>=1.32,<2; python_version>="3.9" pyarrow>=6,<7; python_version < "3.8" pyarrow>=16,!=19.0.0,<20; python_version >= "3.8" -pyroaring<=0.3.3; python_version < "3.7" -pyroaring<=0.4.5; python_version == "3.7" -pyroaring>=1.0.0; python_version >= "3.8" +pyroaring>=1.0.0 Review Comment: Paimon still advertises Python 3.6/3.7 support (`python_requires=">=3.6"` and classifiers), but `pyroaring>=1.0.0` only publishes wheels for cp38+ on PyPI, so Python 3.6/3.7 users fall back to building the sdist. That is a regression from the previous 0.3.x/0.4.x pins, which had cp36/cp37 wheels, and it is especially risky for slim/container installs without a compiler toolchain. Please either raise Pypaimons supported Python version to 3.8+, or add CI/build support that proves the source build works on 3.6/3.7. ########## paimon-python/dev/requirements.txt: ########## @@ -30,9 +30,7 @@ polars>=1,<2; python_version=="3.8" polars>=1.32,<2; python_version>="3.9" pyarrow>=6,<7; python_version < "3.8" pyarrow>=16,!=19.0.0,<20; python_version >= "3.8" -pyroaring<=0.3.3; python_version < "3.7" -pyroaring<=0.4.5; python_version == "3.7" -pyroaring>=1.0.0; python_version >= "3.8" +pyroaring>=1.0.0 Review Comment: Paimon still advertises Python 3.6/3.7 support (`python_requires=">=3.6"` and classifiers), but `pyroaring>=1.0.0` only publishes wheels for cp38+ on PyPI, so Python 3.6/3.7 users fall back to building the sdist. That is a regression from the previous 0.3.x/0.4.x pins, which had cp36/cp37 wheels, and it is especially risky for slim/container installs without a compiler toolchain. Please either raise Pypaimon's supported Python version to 3.8+, or add CI/build support that proves the source build works on 3.6/3.7. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
