aisk commented on code in PR #8420: URL: https://github.com/apache/paimon/pull/8420#discussion_r3520190191
########## paimon-python/dev/requirements.txt: ########## @@ -30,9 +30,7 @@ polars>=1,<2; python_version=="3.8" polars>=1.32,<2; python_version>="3.9" pyarrow>=6,<7; python_version < "3.8" pyarrow>=16,!=19.0.0,<20; python_version >= "3.8" -pyroaring<=0.3.3; python_version < "3.7" -pyroaring<=0.4.5; python_version == "3.7" -pyroaring>=1.0.0; python_version >= "3.8" +pyroaring>=1.0.0 Review Comment: 您好，这个问题已经在原来的PR里讨论过不止一次了。你提供的两个方案，1，升级 Pypaimon 最低依赖到 3.8，在原来的 PR 被您亲自否定了；2，增加 CI 验证源码构建是否在 3.6 / 3.7 下是否构建通过，实际上就是原来 PR 里做的主要工作，并且也已经验证了 pyroaring 可以在 3.6 / 3.7 下通过，但是你要求拆分 PR，当前 PR 就是拆分出来的部分。 不过为了避免更多讨论，我先调研一下在 3.6 / 3.7 下不依赖 pyroaring 来实现 btree global index 并且保持兼容是否可行。感谢 review。 Hello, this issue has already been discussed more than once in the original PR. Regarding the two options you suggested: Raising the minimum Pypaimon dependency to Python 3.8 was explicitly rejected by you in the original PR. Adding CI to verify whether the source build passes on Python 3.6 / 3.7 is essentially the main work that was done in the original PR. It has also already been verified that pyroaring can build successfully on Python 3.6 / 3.7. However, you asked for the PR to be split, and the current PR is the extracted part of that work. That said, to avoid further discussion, I will first investigate whether it is feasible to implement the B-tree global index on Python 3.6 / 3.7 without depending on pyroaring, while still preserving compatibility. Thank you for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
